Skip to content

Lazarev#31

Open
TheAndrewLa wants to merge 28 commits into
Kakadu:masterfrom
TheAndrewLa:master
Open

Lazarev#31
TheAndrewLa wants to merge 28 commits into
Kakadu:masterfrom
TheAndrewLa:master

Conversation

@TheAndrewLa

@TheAndrewLa TheAndrewLa commented Apr 18, 2026 •
edited
Loading

Copy link
Copy Markdown
  • Base task
  • Boolean type
  • Tuple types

upd:

  • Exceptions

@TheAndrewLa
Initial commit
b130941
@TheAndrewLa
Updated project info
af59cda
@TheAndrewLa
Revert "Updated project info"
6d486ae 
This reverts commit af59cda.
@TheAndrewLa
Updated project info
cb9638e 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
AST & Parsing done
0ffac30 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Add wildcard names to generator
07aa153 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Interpreter finished
77bb3f5 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Refactor library code
1c1cf92 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Add REPL
39cf06c 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Fix interpreter to respect step limit
1108854 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Fix interpreter to respect step limit 2
dba7ab4 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Add new tests
8d8a15c 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Fix ocaml_text directives
60fc427 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Fix unused type declaration
951e628 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
github-actions[bot]
github-actions Bot reviewed Apr 18, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/lib/interpreter.ml Outdated
Comment thread Lazarev/lib/interpreter.ml Outdated
Comment thread Lazarev/lib/parser.ml Outdated
Comment thread Lazarev/lib/parser.ml Outdated
Comment thread Lazarev/lib/parser.ml Outdated
Comment thread Lazarev/lib/parser.ml Outdated
@TheAndrewLa
Fix liter comments
22fb0a9 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Fix liter comments 2
9d07934 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Fix linter comments 3
ad56f25 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Fix linter comments 4
84eb5c7 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
github-actions[bot]
github-actions Bot reviewed Apr 18, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
@TheAndrewLa
Fix REPL help message, Add new tests
954b515 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
github-actions[bot]
github-actions Bot reviewed Apr 18, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
@TheAndrewLa
Fix: configuration files
0a8a556 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Add exceptions to AST
35f5971 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Add exceptions to parser
87f6056 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Add exceptions to Interpreter
3aad835 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
github-actions[bot]
github-actions Bot reviewed Apr 20, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
@TheAndrewLa
Add qcheck dep. to project file
0e93667 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
github-actions[bot]
github-actions Bot reviewed Apr 20, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml Outdated
Comment thread Lazarev/bin/REPL.ml Outdated
@TheAndrewLa
Removed weird tests
b7b77b3 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Minor fixes in library
4d8a2f7 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@TheAndrewLa
Fix: REPL is *loop* now
447192e 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
github-actions[bot]
github-actions Bot reviewed Apr 21, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml
@TheAndrewLa
Add 'let exception ...' construction
3f9cebe 
Signed-off-by: Andrew Lazarev <andrew.lzrv@gmail.com>
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

Документация и тестовое покрытие (96.93%) должны скоро появиться.

https://kakadu.github.io/fp25/docs/Lazarev

https://kakadu.github.io/fp25/cov/Lazarev

2026-04-21 11:02

github-actions[bot]
github-actions Bot reviewed Apr 21, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zanuda-linter report

Comment thread Lazarev/bin/REPL.ml
module Interpreter = Mini_ml_lib.Interpreter
module Parser = Mini_ml_lib.Parser

type opts = { mutable env : Interpreter.env }

@github-actions github-actions Bot Apr 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable references and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

Linter report from 2026-04-21 11:03, for mini language Lazarev

File "bin/REPL.ml", line 13, characters 14-43:
13 | type opts = { mutable env : Interpreter.env }
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Alert zanuda-linter: Using mutable data structures for teaching purposes is usually discouraged. Replace Hashtables by standard tree-like maps or consider Hash-Array Mapped Tries (HAMT). Use mutable `ref`erences and mutable structure fields only if it is really required. In all places where it is needed indeed, describe in a comment why it is needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheAndrewLa